junrushao commented on code in PR #78:
URL: https://github.com/apache/tvm-ffi/pull/78#discussion_r2404762297
##########
src/ffi/function.cc:
##########
@@ -64,14 +66,15 @@ class GlobalFunctionTable {
metadata_data = String(method_info->metadata.data,
method_info->metadata.size);
func_data =
AnyView::CopyFromTVMFFIAny(method_info->method).cast<ffi::Function>();
this->SyncMethodInfo(method_info->flags);
- // no need to update method pointer as it would remain the same as func
and we retained
Review Comment:
turns out I initialized `this->method` inside `SyncMethodInfo` just to be
safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
