Hi Sean!
> I've created a new jQuery plugin, jMP3, to easily make MP3s playable
> directly on most any web site.
>
> Information, demos and code:
> http://www.sean-o.com/jquery/jmp3/
>
> Let me know what you think. It's my first plugin, so be gentle!
>
What I like about it:
It works on Opera 8.54 & 9.02 and IE7RC1, too.
Clean and structured code, good examples provided. There were some
updates to the Plugins/Authoring guide which you may want to include.
What I don't like:
You extracted the playerpath, but not the name of the player object
itself: Would be nice to have that extracted into the playerpath.
The code to create the object element is quite clumsy. For performance
reasons, you should use an array with join(""). For code readability,
something else is necessary, but I haven't a good solution for this at hand.
It is not unobtrusive: I don't get anything useful without JS, though no
JS is necessary for the flash object. It's true that the object code is
quite clumsy, but this should be handled by a plugin or template on the
server-side. This point makes your plugin pretty useless on sites, that
don't strictly require JS. In that case, your plugin is nice, because
you don't have to implement the plugin for every server-side scripting
language available...
Good work, anyway!
-- Jörn
_______________________________________________
jQuery mailing list
[email protected]
http://jquery.com/discuss/
