I kind of like that Issue-ID: ISSUE-1. Is that a typical footer in other upstreams? If so, this looks like the best footer to include.
So I guess OpenStack uses Closes-Bug: ##### as ways to move bugs through states - which we don't have. On Thu, Apr 5, 2018 at 10:54 AM, Andrew Grimberg < [email protected]> wrote: > On 04/05/2018 09:32 AM, Sam Hague wrote: > > What would the workflow be with the new jira and gerrit integration? And > > what best-practices should be used when creating commit messages? > > > > Typically users have included the bug-id in the beginning of the summary > > line. That eats up some of the 50 characters allowed so it isn't good. > > Should we encourage something more like what openstack is doing in [1] > > where they suggest adding lines in the message themselves like > > "Closes-Bug: #####", "Partial-Bug: #####"? This seems better and gives > > more space to the commit-message summary line. > > > > Thanks, Sam > > > > [1] > > https://docs.openstack.org/infra/manual/developers.html# > development-workflow > > LFRE has been actively discouraging putting your Issue IDs in the commit > subject line. At least on the repos that we're active on. > > Most of our communities are using a footer line of 'Issue-ID: ' or > 'Issue-Id: '. > > We've got two communities that requested that we force having issue > identifiers in all commits (something I actually dislike) but we've done > that. On those projects (ONAP, and I don't remember which other one) you > can't even submit a change to Gerrit if you don't have an 'Issue-ID: > ISSUE-1' type footer line. > > As for the rest of the bits on closes / partial. We have not implemented > anything on the JIRA side outside of looking up if there are any Gerrit > changes that reference the issue. As such, moving issues through the > process are still going to require you to manually move the issues. > > -Andy- > > -- > Andrew J Grimberg > Lead, IT Release Engineering > The Linux Foundation > >
_______________________________________________ Discuss mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/discuss
