No strong preference, but throwing one more option

Resolves:NETVIER-1234? More obvious?

iPhone.iTypos.iApologize

> On Apr 16, 2018, at 7:21 AM, Sam Hague <sha...@redhat.com> wrote:
> 
> OK, anymore votes?
> 
> So far we have:
> 
> NETVIRT-1234
> Issue: NETVIRT-1234
> JIRA: NETVIRT-1234
> 
> In all cases, the important part is just the Id NETVIRT-1234 since that will 
> be linked to Jira automagically. Jira and Issue are almost the same since 
> Jira uses Issues. I am leaning towards Issue or JIRA, but I admit I don't 
> have a preference yet.
> 
> 
> 
>> On Mon, Apr 16, 2018 at 1:21 AM, Robert Varga <n...@hq.sk> wrote:
>> On 06/04/18 09:18, Michael Vorburger wrote:
>> > On Fri, Apr 6, 2018 at 12:16 AM, Thanh Ha <thanh...@linuxfoundation.org
>> > <mailto:thanh...@linuxfoundation.org>> wrote:
>> > 
>> >     On Thu, Apr 5, 2018 at 12:32 PM, Sam Hague <sha...@redhat.com
>> >     <mailto:sha...@redhat.com>> wrote:
>> > 
>> >         What would the workflow be with the new jira and gerrit
>> >         integration? And what best-practices should be used when
>> >         creating commit messages?
>> > 
>> >         Typically users have included the bug-id in the beginning of the
>> >         summary line. That eats up some of the 50 characters allowed so
>> >         it isn't good. Should we encourage something more like what
>> >         openstack is doing in [1] where they suggest adding lines in the
>> >         message themselves like "Closes-Bug: #####", "Partial-Bug:
>> >         #####"? This seems better and gives more space to the
>> >         commit-message summary line.
>> > 
>> >         Thanks, Sam
>> > 
>> >         [1]
>> >         
>> > https://docs.openstack.org/infra/manual/developers.html#development-workflow
>> >         
>> > <https://docs.openstack.org/infra/manual/developers.html#development-workflow>
>> > 
>> > 
>> >     I've always recommend folks treat the footer block in a commit
>> >     message as metadata. Things like bug IDs should go there so it will
>> >     look like:
>> > 
>> >     Summary line
>> > 
>> >     Message body
>> >     continued body lines...
>> > 
>> >     NETVIRT-1234
>> 
>> JIRA: NETVIRT-1234
>> 
>> It is good to point towards a particular namespace domain -- note how
>> the Bugzilla -> Jira changed names...
>> 
>> >     Change-Id: ....
>> >     Signed-off-by: .... 
>> > 
>> > 
>> >     You can add words in front of the Jira ID too like "closes:"
>> >     "Issue:", "fixes", etc... I'm not sure if the Jira integration
>> >     supports any specific words but I know it picks up at least he Jira ID.
>> > 
>> > 
>> > I like the "Issue: NETVIRT-1234" syntax (finding an upper case "-ID"
>> > ugly, and "Issue-Id" superfluous)... I'll start using that in footers in
>> > future work.
>> > 
>> >     Regards,
>> >     Thanh
>> > 
>> > 
>> > 
>> > 
>> > _______________________________________________
>> > Discuss mailing list
>> > Discuss@lists.opendaylight.org
>> > https://lists.opendaylight.org/mailman/listinfo/discuss
>> > 
>> 
>> 
>> _______________________________________________
>> TSC mailing list
>> t...@lists.opendaylight.org
>> https://lists.opendaylight.org/mailman/listinfo/tsc
>> 
> 
> _______________________________________________
> TSC mailing list
> t...@lists.opendaylight.org
> https://lists.opendaylight.org/mailman/listinfo/tsc
_______________________________________________
Discuss mailing list
Discuss@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/discuss

Reply via email to