Sounds like we have a winner. I've proposed a patch to make this change here:
https://gerrit.linuxfoundation.org/infra/10395 but it will be low priority to merge as this change requires a maintenance window so we will merge it whenever the next maintenance happens to be. This change as is would also "fix" or "break" depending on how you look at it the issue of random UPPERCASE-#### pattern text producing invalid URL patterns when someone pastes for example a full link to another Jira system. The "breakage" however is if someone listed "NETVIRT-1234" without the JIRA: prefix it will no longer automatically assume that's a link to the OpenDaylight Jira system. I'm not sure if it would be possible to support both syntaxs as I'm not sure how Gerrit will react if there's 2 patterns that match on the same case. Let me know if anyone things this is a problem and we can reject the patch. Regards, Thanh On Thu, May 3, 2018 at 5:24 AM, Lori Jakab <[email protected]> wrote: > +1 > > On Thu, May 3, 2018 at 4:20 AM, Daniel Farrell <[email protected]> > wrote: > >> On Wed, May 2, 2018 at 6:59 PM Thanh Ha <[email protected]> >> wrote: >> >>> Hi Everyone, >>> >>> If we have consensus on the recommended format we can setup the Jira >>> plugin to suggest the format when folks push patches but setting the >>> "association: SUGGESTED" setting in the plugin config. >>> >>> https://gerrit.googlesource.com/plugins/its-jira/+doc/master >>> /src/main/resources/Documentation/config.md >>> >>> This setting won't force you to add any IDs but it will at least notify >>> the contributor that if they would like to set one, it will suggest a >>> recommended format to their client when they push a patch. (I would >>> recommend against setting it to MANDATORY because then it would require us >>> to have a Jira for every patch regardless of how trivial the contribution >>> is). >>> >>> So far I think the current winner is the format "JIRA: NETVIRT-1234". Is >>> there anyone who disagrees to set this as the recommended format moving >>> forward? >>> >> >> +1 >> >>> >>> Regards, >>> Thanh >>> >>> >>> On Mon, Apr 16, 2018 at 1:29 PM, Jamo Luhrsen <[email protected]> >>> wrote: >>> >>>> my vote, which is worth 0.02 is for "JIRA: NETVIRT-1234" >>>> >>>> JamO >>>> >>>> On 4/16/18 8:22 AM, Anil Vishnoi wrote: >>>> >>>>> No strong preference, but throwing one more option >>>>> >>>>> Resolves:NETVIER-1234? More obvious? >>>>> >>>>> iPhone.iTypos.iApologize >>>>> >>>>> On Apr 16, 2018, at 7:21 AM, Sam Hague <[email protected] <mailto: >>>>> [email protected]>> wrote: >>>>> >>>>> OK, anymore votes? >>>>>> >>>>>> So far we have: >>>>>> >>>>>> NETVIRT-1234 >>>>>> Issue: NETVIRT-1234 >>>>>> JIRA: NETVIRT-1234 >>>>>> >>>>>> In all cases, the important part is just the Id NETVIRT-1234 since >>>>>> that will be linked to Jira automagically. Jira and Issue are almost the >>>>>> same since Jira uses Issues. I am leaning towards Issue or JIRA, but I >>>>>> admit I don't have a preference yet. >>>>>> >>>>>> >>>>>> >>>>>> On Mon, Apr 16, 2018 at 1:21 AM, Robert Varga <[email protected] <mailto: >>>>>> [email protected]>> wrote: >>>>>> >>>>>> On 06/04/18 09:18, Michael Vorburger wrote: >>>>>> > On Fri, Apr 6, 2018 at 12:16 AM, Thanh Ha < >>>>>> [email protected] <mailto:[email protected]> >>>>>> > <mailto:[email protected] <mailto: >>>>>> [email protected]>>> wrote: >>>>>> > > On Thu, Apr 5, 2018 at 12:32 PM, Sam Hague < >>>>>> [email protected] <mailto:[email protected]> >>>>>> > <mailto:[email protected] <mailto:[email protected]>>> >>>>>> wrote: >>>>>> > > What would the workflow be with the new jira and >>>>>> gerrit >>>>>> > integration? And what best-practices should be used when >>>>>> > creating commit messages? >>>>>> > > Typically users have included the bug-id in the >>>>>> beginning of the >>>>>> > summary line. That eats up some of the 50 characters >>>>>> allowed so >>>>>> > it isn't good. Should we encourage something more like >>>>>> what >>>>>> > openstack is doing in [1] where they suggest adding >>>>>> lines in the >>>>>> > message themselves like "Closes-Bug: #####", >>>>>> "Partial-Bug: >>>>>> > #####"? This seems better and gives more space to the >>>>>> > commit-message summary line. >>>>>> > > Thanks, Sam >>>>>> > > [1] >>>>>> > https://docs.openstack.org/in >>>>>> fra/manual/developers.html#development-workflow >>>>>> <https://docs.openstack.org/infra/manual/developers.html#dev >>>>>> elopment-workflow> >>>>>> > <https://docs.openstack.org/i >>>>>> nfra/manual/developers.html#development-workflow >>>>>> <https://docs.openstack.org/infra/manual/developers.html#dev >>>>>> elopment-workflow>> >>>>>> > > > I've always recommend folks treat the footer >>>>>> block in a commit >>>>>> > message as metadata. Things like bug IDs should go there so >>>>>> it will >>>>>> > look like: >>>>>> > > Summary line >>>>>> > > Message body >>>>>> > continued body lines... >>>>>> > > NETVIRT-1234 >>>>>> >>>>>> JIRA: NETVIRT-1234 >>>>>> >>>>>> It is good to point towards a particular namespace domain -- note >>>>>> how >>>>>> the Bugzilla -> Jira changed names... >>>>>> >>>>>> > Change-Id: .... >>>>>> > Signed-off-by: .... > > > You can add words >>>>>> in front of the Jira ID too like "closes:" >>>>>> > "Issue:", "fixes", etc... I'm not sure if the Jira >>>>>> integration >>>>>> > supports any specific words but I know it picks up at least >>>>>> he Jira ID. >>>>>> > > > I like the "Issue: NETVIRT-1234" syntax (finding an >>>>>> upper case "-ID" >>>>>> > ugly, and "Issue-Id" superfluous)... I'll start using that in >>>>>> footers in >>>>>> > future work. >>>>>> > > Regards, >>>>>> > Thanh >>>>>> >>>>> _______________________________________________ >>> dev mailing list >>> [email protected] >>> https://lists.opendaylight.org/mailman/listinfo/dev >>> >> >> _______________________________________________ >> TSC mailing list >> [email protected] >> https://lists.opendaylight.org/mailman/listinfo/tsc >> >> >
_______________________________________________ Discuss mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/discuss
