I think it's easier to reason about the correctness when protocols is final.
Note that with that patch there is a race condition in setProtocols; for example, two calls to setProtocols with different lists might end up with the concatenation of the two lists, rather than one or the other. I don't think this is worth worrying about, since I suspect that setProtocols exists for setter injection purposes only, in which case it's fine as is. (But it should be documented as such.) I have no ability to submit that patch, and there's no issue (is there?), so other folks will need to figure out what to do here. --tim On Dec 28, 2007 5:09 PM, Rob Heittman <[EMAIL PROTECTED]> wrote: > I wasn't sure whether to leave protocols null or make a new > CopyOnWriteArrayList(). Either one seems to work.
