On Dec 28, 2007 5:32 PM, Kevin Conaway <[EMAIL PROTECTED]> wrote:

> I attached your patch to 368.


Sure hope it works -- I didn't compile it or test it. :-(



> setProtocols() could be renamed to addProtocols() with the
> protocols.clear() call removed.
>
> That communicates the intention a little better.
>

Agreed, but would you then add a clearProtocols method or was the original
intention purely setter-injection, in which case addProtocols (to an empty
list) is all one would ever need?

--tim

Reply via email to