Hi all, I've applied Tim's patch to the trunk. The current usage of setProtocols() is mostly for setter injection indeed. Couldn't we simply mark the method as synchronized?
Best regards, Jerome > -----Message d'origine----- > De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] De la > part de Tim Peierls > Envoyé : samedi 29 décembre 2007 01:56 > À : [email protected] > Objet : Re: ServerServlet broken by concurrency fix in 1.1M1 > > On Dec 28, 2007 5:32 PM, Kevin Conaway > <[EMAIL PROTECTED]> wrote: > > > I attached your patch to 368. > > > Sure hope it works -- I didn't compile it or test it. :-( > > > > > setProtocols() could be renamed to addProtocols() with the > protocols.clear() call removed. > > That communicates the intention a little better. > > > > Agreed, but would you then add a clearProtocols method or was > the original intention purely setter-injection, in which case > addProtocols (to an empty list) is all one would ever need? > > --tim > >
