Agreed, I've update Component as suggested, for all collection fields. Best regards, Jerome
> -----Message d'origine----- > De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] De la > part de Tim Peierls > Envoyé : jeudi 3 janvier 2008 23:03 > À : [email protected] > Objet : Re: ServerServlet broken by concurrency fix in 1.1M1 > > Thanks! > > An additional nice touch would be to make Component.hosts > final, which would require moving its initialization outside > the if statements in the constructor. Maybe some of the other > fields, too? It's one less thing to worry about for these fields. > > --tim > > On Jan 3, 2008 4:22 PM, Jerome Louvel <[EMAIL PROTECTED]> wrote: > > > I've done the discussed changes + javadocs on Component > and Connector. > > > > -----Message d'origine----- > > > ...could you add a comment along the lines of > > "synchronized to make compound action (clear, addAll) > atomic, not for visibility"? > > > >
