Malcolm Tredinnick wrote:
>>      return s.substring(0, num_chars);// trim to first num_chars chars
>>      return s.substring(0, num_chars);// trim to first num_chars chars
>> }
>> ]]]
> 
> Probably only one of the last two lines is necessary. :-)

DRY!

> I am the about the worst guy in the world to review Javascript code, but
> I agree it seems to behave logically. I'm just not familiar enough with
> the ins and outs enough to spot any sneaky problems that might creep
> into code like this. Fortunately, the audience is full of people with
> real clues.

Fair enough; it's out there so people can push back on the approach, 
before I crack on.


> Anyway, thanks for doing the work, Bill. This looks like something that
> is a great start and that we can tweak as people find problems in their
> own locales.

Ok, I'll start testing this and filling in some mappings. I'll send in a 
patch as soon as I can.

cheers
Bill



--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers
-~----------~----~----~----~------~----~------~--~---

Reply via email to