On 2007-07-09 09:45:34 -0600, "Russell Keith-Magee" <[EMAIL PROTECTED]> said:
> > Hi all, > > Attached to #4418 is the latest version (v3) of the newforms Media > patch. It incorporates some suggestions made before I disappeared on > my grand adventure last month. > > For those not keeping track, the idea of this patch is to enable a > newforms widget to define the javascript/css that it requires; then, > when a form is generated that uses that widget, it is possible to > determine the minimum set of javascript/css that is required to render > the form. More details on the ticket; example usage in the regression > test. > > Other than needing some documentation, I think this is pretty close to > being ready for committal. At last count, Jacob was +1 to the idea, > Malcolm said the idea was growing on him but he hadn't looked at the > patch. Any feedback (especially objections to committing) would be > appreciated. > > Changes in this version of the patch: > > - It handles https, as well as https absolute paths. > > - <script> tags are closed with a </script> rather than being <script /> tags. > > - CSS definitions are now dictionaries, rather than lists. This allows > for CSS for different media types. See the regression tests for > examples of usage. > > - Inherited widgets now inherit the media of their parents, unless overridden. > > - MultiWidgets inherit the media definitions of their component widgets. > > - Fixed a problem with the addition operator on Media objects. > > I have also attached the same patch with some extra bits for the > newforms-admin branch. With this patch applied: > > - FormSets, FieldSets and AdminForms can be interrogated for media, > just like Forms > > - Any application can reference an 'AdminDateWidget' or > 'AdminTimeWidget' and they will get all the javascript definitions > required to render a pretty calendar/time widget > > - Date/Time widgets now always appear on inline forms when required. > Previously, they wouldn't be displayed unless the base form also > required the widget. > > Yours, > Russ Magee %-) > > This is an excellent patch and does solve many good issues as well as add some good new functionality. One thing I want to point it is ticket #4398. You might want to make sure that is also incorporated. -- Brian Rosner http://www.brosner.com/blog --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
