On 7/10/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote:
>
> On 7/9/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote:
> > Attached to #4418 is the latest version (v3) of the newforms Media
> > patch. It incorporates some suggestions made before I disappeared on
> > my grand adventure last month.
>
> I see there are some not-insignificant changes to the admin site; it'd
> be much easier if this were a patch against the newforms-admin branch,
> as that branch has changed much of that admin code. What do you say?

That was going to be my next question - whether to push this into
trunk or newforms-admin. In playing with the code last night, I was
thinking that newforms-admin might be a better idea, so we can work
out the little kinks before we push the API into trunk.

Should I take that as clearance to push this into newforms-admin?

> Also, what happens when a form has defined a field called "media"?

I haven't tried this explicitly, but the behavior should be no
different to a form that has a field called 'clean', 'reset', or uses
any other method name that is on the BaseForm class.

> Other than that, this patch needs some documentation to
> docs/newforms.txt before it can be checked in.

Granted. I just wanted to make sure that the interface was solid
before I started writing.

Russ %-)

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to