On 9/9/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > > On Sun, 2007-09-09 at 21:46 +0800, Russell Keith-Magee wrote: > > No - this has nothing to do with the test framework. It's a set of > > helper functions to support writing clean_XXX methods. > > Okay. Then I'm mostly in agreement, except that I have two small > problems with your "for consistency arguments": > > (1) They shouldn't be called "assertXYZ". Assertions are typically > things that should never, ever fail. It's a programming error if they > do. Passwords failing to match are not assertion failures. That's just a > normal error checking path. ... > (2) We should use Django's normal naming scheme (underscores, etc), ... > Once you move away from using "assert", confusion with the unittest > names will fade and the methods will be more self-explanatory. Maybe > call them validate_equal(), validate_not_equal(), etc.
Both valid points. Ok, sign me up for self.validate_equal() on BaseForm. Yours, Russ Magee %-) --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
