+1 And I think that an equally important point here is not necessarily that people can subclass an existing generic view, but that they can subclass BaseView for an easier way to create their own generic views. Anything which makes good practices for reusable apps easier is a win in my book.
About the bikeshed, I might paint it "finish", although I think that post_save isn't such a bad name either. -Eric On Mar 7, 1:17 pm, "Joseph Kocherhans" <[EMAIL PROTECTED]> wrote: > I just uploaded a patch [1] for class based generic views that use > ModelForm internally. Personally, I think this makes the generic views > a lot more flexible, and gives us a great argument against > adding-yet-another-config-argument-to-generic-views (even though I > haven't heard that particular demand come up for awhile.) Just > subclass the generic view, and do what you need. > > Anyhow, here's what I have in mind for the backwards compatibility story: > > This patch leaves the old generic views as-is, using manipulators. > This partially fixes the problem, we get ModelForm based generic views > living side by side with the old manipulator based ones. People can > svn up without breaking anything, and convert their code at their > convenience. At some point I think we'll want to either get rid of the > old functions, or convert them to use the new classes (should be > trivial). Personally, I'd rather do the former, but I'm probably in > the minority there. > > Malcolm has pointed out that the post_save method is probably not such > a great name. I agree. So, what color would *you* paint that > particular bikeshed? > > Joseph > > [1]http://code.djangoproject.com/ticket/6735 --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
