On Tue, 2008-11-25 at 10:28 -0600, Jacob Kaplan-Moss wrote: > On Tue, Nov 25, 2008 at 10:11 AM, Johannes Dollinger > <[EMAIL PROTECTED]> wrote: > > I'm aware that #7806 propably does too much at once. I'd like to hear > > what's in scope for 1.1 and what you believe doesn't belong in django. > > I'm actually pretty happy with the general idea you've taken here -- > django.template needs some cleanup, and a holistic approach that > addresses the multiple issues at once is going to produce better code > than multiple patches all stacked up. > > It seems most of the core team agrees -- it got 7 +0 votes. I think > the only reason it failed to get any +1s is that it's just a big > amount of work to review all at once. There's also the obvious > question of weather we can pull off this refactoring without breaking > backwards-compatibility. > > I think the best thing to do with this is to take it to a branch so we > can easily evaluate it against the trunk templates. If you're down for > working on this off on a branch, I'm willing to help out and also > review your code.
I agree with the mini-branch approach (particularly since Jacob's volunteered to shepherd it). However, one thing I'm cautious about and that I'd like to keep split out: a bunch of the bugs such as filtering in ifequal tags, etc, can be fixed fairly simply and they're legitimate bug fixes that can be applied to 1.0.X as well as trunk. So I've always been thinking of this as a two-phase process: fixing most of the bugs and then the refactoring separately. The first part can then easily be applied to the 1.0.X branch as well. Whether phase one is done on a branch or just a bunch of small patches (and most of them will be relatively small) is a separate issue. If Russell ever gets his recently announced +4 Fountain of Free Time installed in his backyard, I'm flying out to Perth to have a drink from it and then fix the bug portion, but right at the moment I'm not holding my breath. My TODO list looks scary enough that if other people are doing this, I'll just step back and kibitz. Regards, Malcolm --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
