Many thanks on the feedback all. I wanted to let you know I'm working on an updated proposal removing 1) and 4) and replacing them with a collection of convenience assertions/functions for core test stuff.
On Tue, Mar 31, 2009 at 8:15 PM, Jacob Kaplan-Moss < jacob.kaplanm...@gmail.com> wrote: > > On Tue, Mar 31, 2009 at 8:52 PM, Russell Keith-Magee > <freakboy3...@gmail.com> wrote: > > I like the sentiment and the goal - my only concern is the extent to > > which this is in scope for a Django GSoC project. If making this > > integration requires changes on the Django side, you're fine - but if > > you need to make changes on the Nose/Windmill side, then you have a > > problem, as we don't have any control over those projects. Also - I > > was under the impression that both Nose and Windmill already had > > Django interfaces of some description. I could be mistaken - I haven't > > really used either of them extensively myself. > > I'm not sure about Nose either, but Windmill has Django support, and > actually grew a management comment as part of the PyCon sprints. > You'll add 'windmill' to INSTALLED_APPS, and then run `manage.py > test_windmill` (or similar); see > http://trac.getwindmill.com/changeset/1172. > > So we don't have to make a single change to Django to make that > support work, which makes me very happy :) > > > Requiring Windmill here makes me a little nervous. I have no > > experience with Windmill to know if it is a good choice for this task. > > AFAIK the two choices for doing browser tests are Selenium and > Windmill. Windmill has (as of today) direct Django integration, and > the developers are keen to help us get whatever we need out of > Windmill. Selenium doesn't, and I don't know what the developer's > priorities are. I don't see that it's that hard a choice given the > alternatives. > > > I don't want to just add Windmill tests because we can - we need to be > > adding tests that actually add value for regression purposes. It's > > very easy to write functional tests that don't actually validate > > functionality - they just make it difficult to modify code. > > We *really* need coverage of the admin UI. Working on the admin > actions, I've twice checked in JavaScript that doesn't work on IE. We > wouldn't tolerate committing code broken on MySQL; why do we tolerate > code broken on IE? I see adding functional UI tests as a necessity if > we want to keep adding new admin features. > > > We also need to ensure that the test suite continues to run for those > > that haven't got Windmill installed (albeit with a warning). > > Indeed. Anything else is broken. > > > There is > > an old ticket that proposed to allow skipping tests that are known > > failures, reporting them as 'known failures/skipped tests' rather than > > outright failures. This might be something worth including in your > > proposal. > > Yeah, it's http://code.djangoproject.com/ticket/4788; that'd make an > obvious addition to the project. Kevin, you should take a look at the > skip-test feature added to Python (trunk) recently; might be worth > ripping off... err... adapting for our purposes. > > > django-test-utils is a great set of tools, but working on those tools > > is (IMHO) out of scope for the SoC, since it isn't part of the Django > > project itself. > > Agreed. Find Django core stuff to work on, not third-party projects. > > > I was under the impression that GSoC was intended to be a full-time > > activity - however, I couldn't find any reference to this in the FAQ. > > You may want to confirm that a 'part time' application is allowed. > > Google doesn't specify > ( > http://socghop.appspot.com/document/show/program/google/gsoc2009/faqs#student_time);some > projects require full-time status, but I'm OK with not as long as the > student's up front about how much time he'll be able to spend. Given > that none of *us* work full-time on Django I don't see that we should > absolutely require our students to do so. > > Jacob > > > > -- Kevin Kubasik http://kubasik.net/blog --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
