On Sun, Jun 20, 2010 at 6:16 AM, Byron <bjr...@gmail.com> wrote:
> Yes I agree. I never quite understood why the
> CACHE_MIDDLEWARE_KEY_PREFIX was implemented, but not at the lower
> level (did the cache API become available after the middleware
> caching?). Of course a custom backend can be written, but then there
> would need to be a different one for each backend type. This is a very
> simple change to BaseCache that provides a means off prefixing. I also
> added a default for `key_prefix' in BaseCache (so current custom
> backends don't need to be rewritten and will work as normal).
>
> BTW, the patch passes all previous tests at that revision (with the
> exception of a non-related markup test?) and I also subclassed all the
> cache tests and added a CACHE_KEY_PREFIX (renamed from
> PROJECT_KEY_PREFIX) for those tests -- they all pass as well. I also
> added a preliminary snippet of documentation that most likely will
> need to be expanded on.
>
> I would appreciate any suggestions, criticisms, etc.

Apologies for not weighing in sooner -- I think this is a reasonable
feature proposal; I've just marked the ticket as accepted. The patch
looks pretty good too, although I've got a couple of light polish
requests. I've attached comments on the ticket.

Yours,
Russ Magee %-)

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to