For the project which I plan to use this is such that all sites could share same INSTALLED_APPS, but it would be truly awesome if full settings were possible for each site.
On Jan 26, 5:10 pm, Lorenzo Gil Sanchez <lorenzo.gil.sanc...@gmail.com> wrote: > I suggest to have a look to www.reviewboard.org since they have solved > this problem a long time ago. Hey thanks! Here is the relevant code (in order of discovery): https://github.com/reviewboard/reviewboard/blob/master/reviewboard/settings.py https://github.com/reviewboard/reviewboard/blob/master/reviewboard/admin/middleware.py https://github.com/reviewboard/reviewboard/blob/master/reviewboard/admin/siteconfig.py (see load_site_config) https://github.com/djblets/djblets/blob/master/djblets/siteconfig/middleware.py (some dynamic settings stuff) Although I would love to see per request settings object, but this is not a way to go. I mean (judging fast) it seems like their implementation is not thread safe: On each request it patches the settings object with own stuff. If the request is not fully served until next request comes, the settings object might get mangled too early. On the other hand if all code were to use get_settings(request=None) instead of django.conf.settings that could work. If we are not trying to achieve thread safeness, then probably one could open up enough workers so that each django instance would serve single request at a time. Maybe they don't use multithreading in reviewboard? -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
