I have apologized on #django-dev as well, but I do feel like I ought to throw my mea culpa up here as well for posterity. I misread Jacob's "I think this is a great idea" to mean "Go ahead and set 'Patch needs Improvement'" on 100 tickets rather than what I should have read "Some method of automatically checking patches and giving some feedback, but without spamming the world would be great".
I let my enthusiasm get the best of me and as penance I'll spend some hours trying to get some of the patches that I just let a script say need improvement to apply cleanly. dave On Thu, May 5, 2011 at 2:00 PM, Jannis Leidel <lei...@gmail.com> wrote: > Hi all, > > After having gotten almost 100 emails from patchhammer via Trac in under a > minute, I'd like to suggest to be a bit less hammer-y and let actual humans > review the patches instead of doing the patch apply check. > > In my experience attached patches usually only need little modification to > land in trunk (if otherwise in good shape), so I see not much usefulness > with auto-adding info that the file needs to be updated to the latest state > of trunk. > > In other words, using a bot on a ticket tracker seems rather counter > productive to me. > > Jannis > > On 05.05.2011, at 13:21, Dave McLain wrote: > > > I've been trying to move along some tickets that are in the 'Patch Needs > Review' category, in the hopes that I might accrue enough karma that > somebody would promote #15900 to ready for commit. > > > > I got frustrated with the number of patches that wouldn't merge with > trunk, so like any sane person would at 2 in the morning I started writing a > script that would screen scrape the Ready For Commit report, download the > patches for every ticket and automatically try to merge them with -p0, -p1 > and the -R for both of those. It's 6am now, so I'm going to bed before > throwing the source up on github, but I'll post the results below and open > source the script in the morning (or afternoon). > > > > The next step would be to automatically set the "Patch Needs Improvement" > bit, but I figured I probably ought to get some more opinions than just a > straw poll on #django-dev. > > > > > > dave > > > > ps. I've got an improvement to #15900 to get rid of it's nasty abuse of > **kwargs, so please don't promote it. Thanks julien. > > > > 2594 - FAIL > > 3202 - SUCCESS > > 4117 - FAIL > > 4198 - FAIL (NO PATCH) > > 4287 - SUCCESS > > 4978 - FAIL (NO PATCH) > > 5014 - SUCCESS > > 5025 - SUCCESS > > 5373 - SUCCESS > > 5418 - FAIL > > 5423 - SUCCESS > > 5446 - FAIL > > 5611 - FAIL > > 5704 - FAIL > > 5789 - FAIL > > 5899 - FAIL > > 6011 - SUCCESS > > 6392 - FAIL > > 6474 - FAIL > > 6610 - FAIL > > 6648 - FAIL > > 8159 - FAIL > > 8261 - FAIL > > 8348 - FAIL > > 8363 - FAIL > > 8500 - FAIL > > 8561 - FAIL > > 8754 - FAIL > > 8901 - FAIL > > 9071 - FAIL > > 9102 - SUCCESS > > 9200 - FAIL > > 9209 - FAIL > > 9368 - FAIL > > 9433 - SUCCESS > > 9459 - FAIL > > 9460 - FAIL > > 9762 - FAIL > > 9800 - SUCCESS > > 9805 - SUCCESS > > 10191 - SUCCESS > > 10436 - FAIL > > 10557 - FAIL > > 10571 - FAIL > > 10725 - SUCCESS > > 10744 - FAIL > > 10790 - FAIL > > 10808 - FAIL > > 10837 - FAIL > > 10843 - FAIL > > 10899 - SUCCESS > > 10944 - SUCCESS > > 10977 - FAIL > > 11133 - FAIL > > 11185 - SUCCESS > > 11212 - SUCCESS > > 11295 - FAIL > > 11487 - FAIL > > 11505 - SUCCESS > > 11515 - FAIL > > 11518 - FAIL (NO PATCH) > > 11555 - SUCCESS > > 11595 - SUCCESS > > 11651 - FAIL > > 11745 - SUCCESS > > 11775 - FAIL > > 11778 - FAIL > > 11911 - SUCCESS > > 11941 - FAIL > > 12091 - FAIL > > 12103 - SUCCESS > > 12183 - FAIL (NO PATCH) > > 12212 - FAIL > > 12308 - FAIL > > 12441 - SUCCESS > > 12464 - FAIL > > 12566 - FAIL > > 12658 - FAIL > > 12713 - SUCCESS > > 12747 - FAIL > > 12753 - SUCCESS > > 12807 - FAIL > > 12823 - FAIL > > 12826 - FAIL > > 12914 - FAIL > > 12972 - FAIL > > 12982 - SUCCESS > > 13043 - FAIL > > 13085 - SUCCESS > > 13154 - FAIL > > 13163 - FAIL > > 13205 - FAIL > > 13211 - FAIL > > 13223 - SUCCESS > > 13247 - FAIL > > 13252 - FAIL > > 13385 - FAIL > > 13559 - FAIL > > 13564 - FAIL > > 13677 - FAIL > > 13721 - FAIL > > 13734 - FAIL > > 13756 - SUCCESS > > 13794 - FAIL > > 13864 - FAIL > > 13875 - FAIL > > 13883 - FAIL > > 13896 - FAIL > > 13926 - FAIL > > 13956 - FAIL > > 14007 - FAIL > > 14045 - FAIL (NO PATCH) > > 14056 - SUCCESS > > 14093 - FAIL > > 14098 - FAIL > > 14129 - FAIL > > 14175 - SUCCESS > > 14202 - SUCCESS > > 14273 - SUCCESS > > 14315 - FAIL > > 14319 - FAIL > > 14390 - FAIL > > 14394 - SUCCESS > > 14396 - FAIL > > 14567 - SUCCESS > > 14571 - FAIL (NO PATCH) > > 14572 - SUCCESS > > 14618 - FAIL > > 14675 - FAIL > > 14678 - SUCCESS > > 14681 - FAIL > > 14757 - SUCCESS > > 14786 - SUCCESS > > 14903 - SUCCESS > > 14958 - FAIL > > 15064 - SUCCESS > > 15098 - SUCCESS > > 15126 - SUCCESS > > 15184 - SUCCESS > > 15206 - SUCCESS > > 15221 - FAIL > > 15231 - SUCCESS > > 15237 - SUCCESS > > 15255 - SUCCESS > > 15263 - FAIL > > 15266 - SUCCESS > > 15281 - FAIL > > 15305 - SUCCESS > > 15321 - SUCCESS > > 15354 - SUCCESS > > 15361 - SUCCESS > > 15499 - FAIL > > 15580 - SUCCESS > > 15595 - SUCCESS > > 15596 - SUCCESS > > 15675 - SUCCESS > > 15715 - SUCCESS > > 15768 - SUCCESS > > 15769 - SUCCESS > > 15782 - SUCCESS > > 15789 - SUCCESS > > 15790 - SUCCESS > > 15805 - SUCCESS > > 15829 - SUCCESS > > 15840 - FAIL > > 15869 - FAIL (NO PATCH) > > 15900 - SUCCESS > > 15907 - SUCCESS > > 15918 - FAIL > > 15935 - SUCCESS > > 15938 - SUCCESS > > 15954 - SUCCESS > > 15963 - FAIL > > > > > > -- > > You received this message because you are subscribed to the Google Groups > "Django developers" group. > > To post to this group, send email to django-developers@googlegroups.com. > > To unsubscribe from this group, send email to > django-developers+unsubscr...@googlegroups.com. > > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to django-developers@googlegroups.com. > To unsubscribe from this group, send email to > django-developers+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
