On Nov 28, 5:36 pm, Jannis Leidel <lei...@gmail.com> wrote: > > Ah, that makes sense, in fact your approach is much closer to what I > remember doing when pip and virtualenv was ported.
Right, since I did those ports originally :-) > Honestly, I'm not sure how hard the merge is, as I'm not sure how much > changed. Martin could probably shed some light on it how he wants to deal > with it (e.g. svnmerge.py or not). Sure. > Fair enough, I just realized that's a discussion we need to have in a > separate thread (~"What's the best approach for migrating Django projects > from 2.X to3.X?") that can be handled later in the porting process. When > in doubt I would rather use a module like six that has community traction > than writing our own though. There are areas where the current code needs to do metaclass-based checks, and that involves delving into the specifics of the implementation of with_metaclass. This being the case, I made a modified version of Benjamin's which uses "_DjangoBase" as the intermediate parent class. IMO we need this to distinguish from other classes implemented using with_metaclass from the official six package. > Personally I'm fine with it, but as you say, it requires discipline > (I broke pip more than once). But it's definitely something that needs > some input from the other core devs, and probably a very good > documentation of the dos and don'ts. Having good code coverage helps to spot these potential breakages well before a release (or even a checkin), and Django's extensive test suite is a boon in this regard. Though having worked through the tests, it doesn't seem like the DRY principle is followed as much as it could be ... for example, the same literals being used over and over again in copy/paste fashion, requiring patches in multiple locations to add u() and b() wrappers, for example. I didn't have time to rationalise this, as I was focused more on identifying and fixing failures and errors. Regards, Vinay Sajip -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
