On Thu, Jan 3, 2013 at 1:56 AM, Malcolm Box <malc...@tellybug.com> wrote:
> Hi, > > When creating self.client in TestCase, it would be very useful if the > testcase instance was passed to the client. > > I'm using a replacement client class that does various validation checks, > so wants to use assert* functions on TestCase, thus takes a testcase > instance as a parameter at creation time. However this means it can't be > used as the client_class attribute on TestCase, as this is instantiated > with no parameters ( > https://github.com/django/django/blob/master/django/test/testcases.py#L475 > ) > > There are work-arounds, but it feels to me like a reasonably generic > requirement that a test client may want to refer to the test case it's > being used with. I think the change can be made largely backwardly > compatible by changing to: > > self.client = self.client_class(testcase=self) > > which would only break an existing replacement client class that had an > __init__ method without **kwargs. > > I'm happy to code this up, but wanted to check for any objections first. > Personally, I'm suspicious of any "A owns B, but B knows about A" relationships. There are certainly occasions when they're required, but whenever they pop up, it's generally an indication of a set of interfaces that are closely coupled. In this case, I'm not sure I see why this coupling is required. A test case is a test case. A test client is a test client. Their concerns are completely separate (evidenced by the fact that you can have a test case without any client usage, and vice versa). I very much see the test client as a utility tool for the test case -- really not much more than a convenient factory for requests -- not an integral part of a test case. Your feature request seems to be stem entirely from the fact that you want to invoke assertions in the test client code itself -- something that you're doing because you've got a bunch of extensions in your test client. I'll leave it up to you to determine if this is the right approach for your own project, but I'm not convinced it's a general requirement that warrants binding the test client to the test case. Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
