On Sun, Nov 10, 2013 at 1:10 AM, Florian Apolloner <[email protected]>wrote:
> Hi Vajrasky, > > > On Saturday, November 9, 2013 4:47:35 PM UTC+1, Vajrasky Kok wrote: >> >> While working on this ticket, I was pondering whether we should really >> fix this or not because one of the core developers said, >> > > Imo fixing this won't be easy; see for instance how admin_urlname filter > is implemented; we'd have a hard time passing anything else in there… > "What is the point of fixing something that we would deprecate in a short >> time?" >> > > Not much. > I'm a little concerned about this talk about deprecation here -- the app_name exists for a reason, and at time the app_name feature was added, it worked (to the best of my knowledge, anyway). > Would it be better if we just raise error if someone provided keyword >> `app_name` argument in AdminSite constructor? This would not break >> backward-incompatibility because this bug had prevented someone to provide >> keyword `app_name` anyway. >> > > Since it's already broken anyways we can just remove it instead of raising > an error. > Erm… or we can fix it. Like I said, it worked when I put it in. If it's been broken subsequently, that strikes me as a bug in the fix, not in the original idea. I'm -1 on deprecating this unless someone can make a good argument for why the underlying concept is somehow flawed, and I'm not convinced it is (since it was working before). Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAJxq84-PfxR%2Bv0ewxQbcGpmQYr3Yf84TM1UvzVq6-B2u5rHN3A%40mail.gmail.com. For more options, visit https://groups.google.com/groups/opt_out.
