On 08/28/2014 06:44 AM, Tim Graham wrote:
> I've implemented the ability to register "deployment checks" by adding
> deploy=True to register: @register("tag_name", deploy=True). These
> checks are only run if you pass the --deploy flag to check. So in
> development you can run `manage.py check --deploy
> --settings=settings_prod` to check your production settings file.
> Running these checks automatically if DEBUG is False would likely give
> them better visibility, but I don't see an easy way of disabling them
> when testing if we did that.This makes sense to me. I don't like the fact that we assume in some places that "DEBUG off means production", and I would not prefer to add another such assumption here. > Regarding settings, would it be preferable to move them into a single > dictionary setting called something like SECURITY_MIDDLEWARE_CONFIG? Sure. FWIW, catching up on the thread, I fully agree with Russ that this should be in core, not contrib, and I agree with Aymeric and Russ that global config is better done via settings than via subclassing middleware. Carl -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/53FFAEF9.5030800%40oddbird.net. For more options, visit https://groups.google.com/d/optout.
