I was initially indifferent about putting the django-secure settings in a dictionary, but the more I've thought about the more I feel Collin is correct; there is no real benefit (just an arguable sense of "tidiness") and there are several negatives (more verbosity in documentation, check warnings, and settings files, more complex to work with in settings-override scenarios).
The django-secure settings are only loosely related to each other to begin with, and there are several existing settings (SECURE_PROXY_SSL_HEADER, X_FRAME_OPTIONS) which would also belong in that conceptual grouping, leaving us with the choice of moving them (needless backwards-compatibility churn) or not moving them (losing the conceptual tidiness which is the only advantage of the dictionary approach in the first place). So after further reflection, I am -1 on putting the django-secure settings into a dictionary. Carl On 08/30/2014 09:35 AM, Collin Anderson wrote: > I still don't see the benefit to a dictionary. It's helpful for > DATABASES and CACHES because there can be multiple of them. > >> It ensures that related settings remain grouped together. > It seems to me a common SECURITY_ prefix should be good enough > > - It satisfies our craving for DRY > A _tiny_ more DRY, but it's _more_ code in your settings.py. Who wants > to type out all those quotes? > > - It artificially lowers len(dir(django.conf.global_settings)). > How is this helpful? > > -- > You received this message because you are subscribed to the Google > Groups "Django developers" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected] > <mailto:[email protected]>. > To post to this group, send email to [email protected] > <mailto:[email protected]>. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/2b6dfad2-055a-4e56-a408-c0b04224f4cc%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/2b6dfad2-055a-4e56-a408-c0b04224f4cc%40googlegroups.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/540231E1.5000603%40oddbird.net. For more options, visit https://groups.google.com/d/optout.
