I don't have a strong opinion on a nested structure for the tests; I merely followed the existing convention for contrib tests that were already in tests/. Note that if we do nest, we still need the "_tests" suffix (or some distinction so to prevent duplicate app_labels from the contrib apps themselves). A nested structure will require additional changes to runtests.py to make it "smarter", and of course moving more tests.
On Tuesday, February 10, 2015 at 5:11:10 PM UTC-5, Shai Berger wrote: > > On Monday 09 February 2015 17:38:27 Markus Holtermann wrote: > > I'm +1 on moving the contrib tests to tests/<app_label>_tests/ . > > > I'm +1 on preventing tests from being packaged with the contrib apps; > I'm also +1 on moving them out of the app folders in the source -- +0 for > the > move's inherent value, but +1 because it makes the above packaging easier. > > But I'm not sure tests/<app_label>_tests/ is the best destination -- I > think > that, just like the contrib apps themselves are collected in a folder, > their > tests should be too. Either django/contrib/tests/ or tests/contrib/ seem > appropriate. > > The point is to keep it clear that the core does not depend on contrib, > and to > make it easier to remove all of contrib to prove it. > > Shai. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/af3c2b54-8b58-4749-b44e-b4f8d8b4f8b0%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
