The SVG option looks good to me as well. While you are there, could you update the "no" icon as done in https://github.com/elky/django-flat-theme/pull/14?
Unless someone can present an argument for keeping IE8 support, I wouldn't worry about it considering it will be end of life about 1 month after the release of Django 1.9. Please send a pull request when you have a chance and don't forget a mention in the 1.9 release notes too. On Sunday, August 16, 2015 at 3:00:45 PM UTC-4, elky wrote: > > Hi guys, > > I made double work for vector icons - now we have Font and SVG icons. > Let's choose what to use. > > *Quoting my comment > <https://code.djangoproject.com/ticket/20597#comment:16> from SVG > discussion here:* > > Well, only week ago I was 100% happy with font icons. But after Collin's > comment I vote for SVG (<img> with svg as a source). > Below I listed advantages/disadvantages for both options. > > > > *Font* > > > - Customizing. Changing icon color with CSS > - Additional 100KB (font file + css) > - Lots of changes in CSS, HTML and JS > - To support IE8: just add *.ttf file (+ 70KB) > - Code Diff: > > https://github.com/django/django/compare/master...elky:font-icons?diff=unified&name=font-icons > > > *SVG* > > > - Much less changes > - Code is elegant - I actually *just replaced* gifs with svg in > CSS. No pseudo-elements. No alignment tweaks > - 25 additional files (requests) but just 19KB in total > - To support IE8: add fallback in CSS (since we already have gif > icons in the repo, my suggestion is to show them in IE8) > - Code Diff: > > https://github.com/django/django/compare/master...elky:svg-icons?diff=unified&name=svg-icons > > And the final and main argument to choose SVG is that some apps use a bit > overridden Django CSS classes so font approach may cause visual issues (I > checked it with few CMS apps). So font approach is an extra headache for > app developers. > > > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/d775ffff-9915-4dcc-a97c-2cc970a072ce%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
