Given that it addresses such a core component I'd probably rather see it deferred to 1.10.
I'd hope that doesn't affect the motivation of the author (it's a fiddly bit of work to get right and its good to see it being addressed) but from my point of view it'd be better to see it really thoroughly reviewed before commit. As one example it's not clear what the preferred resolution of this point <https://github.com/django/django/pull/3852/files#r40087310> should be. Should the `DATA_UPLOAD_MAX_MEMORY_SIZE` guard include accessing `request.body` directly or not? (Related to Tim's point re. documentation.) As I say, its good work, and I'd like to see it reach completion, but its not the sort of change we should be rushing. (I wouldn't oppose a contrary judgement on it tho) -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/54acf290-b08c-487b-ad2d-962bd26e8cb9%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
