+1 from me. blocktrans is really ugly if it has to fit in one line. On Saturday, February 18, 2012 at 7:04:33 AM UTC+1, Glenn Washburn wrote: > > Hello django devers, > > I'd like to reopen discussion on the multiline tag issue (see: > https://code.djangoproject.com/ticket/8652) which was closed 3 three > years ago as "won't fix". The last comment notes that this won't > happen as the decision has been made many times. But there is no link > to any discussion on this topic, so I can only assume mtredinnick's > point two is the supposed reason for not fixing this. > > I've done rudimentary testing on a 6 character change in 1.3.1 to > template.base.tags_re (add the re.S flag to the regex), which appears > to solve the issue. So I don't see all the work which was being > referred to in mtredinnick's point two. Perhaps the template engine > has been rewritten since then. The only test that fails after making > this change (in 1.3.1) is the one that explicitly tests that tgs should > not be multiline. > > Since this change appears to be so low impact and such a simple > change. Are there any reasons why this change shouldn't be included in > django? Maybe I'm missing something. > > Its interesting to note that > https://code.djangoproject.com/ticket/3888, which is referenced in the > issue, is also closed as "won't fix", but appears to be allowed in > 1.3.1. So there is a precedent for "won't fix" issues being included. > > -Glenn > >
-- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/06f69eec-5eac-4a1d-bed3-bf3bbd25a62f%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
