I had assumed this was still a work in progress because there are missing tests and some documentation. The build is passing but the unittest coverage for the new modules seems low or at least not up to the standards I expect for Django contributions. The same for the daphne and asgiref packages which are new requirements. In previous discussions there were talks about performance benchmarks to track potential regressions before this would be accepted similar to the template-based widget rendering change. I don't see any references here or in this work. What is the status of those?
Best, Mark On Tuesday, May 3, 2016 at 9:04:19 PM UTC-4, Andrew Godwin wrote: > > I'm basically slowly fixing the test system failures (mostly because I > introduced some new packages); the patch is ready to go code-wise, just > need to get it green. Let me fix the current set now and see if that pushes > it over the edge. > > (There are some refinements the patch needs in terms of things like making > the enforce_ordering decorator a bit more efficient, but I see these as > being entirely valid things to do after the feature freeze) > > Andrew > > On Tue, May 3, 2016 at 5:57 PM, Tim Graham <timog...@gmail.com > <javascript:>> wrote: > >> Hi Andrew, >> >> How are things going with the patch [0]? Do you think you might have it >> ready by next Monday or so, so that I'll have at least a few days to review >> it before the alpha scheduled for May 16? >> >> [0] https://github.com/django/django/pull/6419 >> >> On Saturday, March 5, 2016 at 7:49:41 PM UTC-5, Andrew Godwin wrote: >>> >>> My intention is still to get it in - the external library is pretty much >>> at the stable point now, and I'm preparing to brand it 1.0. Once I do that, >>> I'll start work on the Django patch. >>> >>> It's made a bit easier by the fact that the code is four repositories, >>> three of which (asgiref, daphne, and asgi_redis) can continue to be >>> separate modules. Only the code in the "channels" repository needs to go >>> into Django itself, and while it's the biggest repo, most of it should slot >>> right in; there's not really much in core itself that needs changing, more >>> about addition and tweaking some imports. >>> >>> Andrew >>> >>> On Sat, Mar 5, 2016 at 4:44 PM, Tim Graham <timog...@gmail.com> wrote: >>> >>>> Hi Andrew, >>>> >>>> What's your thinking about whether or not any of this will make it into >>>> 1.10? The alpha is scheduled for May 16. >>>> >>>> On Saturday, March 5, 2016 at 2:40:05 PM UTC-5, Andrew Godwin wrote: >>>>> >>>>> Hi Chad, >>>>> >>>>> The REST framework request feature integration, in particular, has not >>>>> started yet; Mozilla has been having some issues working out how to pay >>>>> their various grantees, and from my understanding we still haven't >>>>> received >>>>> the grant money yet. >>>>> >>>>> Channels is well underway, but that's only because I'm able to do the >>>>> work now and wait to get paid for it later; I don't expect the same of >>>>> other contributors. >>>>> >>>>> Andrew >>>>> >>>>> On Fri, Mar 4, 2016 at 3:58 PM, Chad Paulson <ch...@healthvana.com> >>>>> wrote: >>>>> >>>>>> I was happy to read that part of the Mozilla Open Source Support >>>>>> program funding that was recently awarded to the Django Software >>>>>> Foundation >>>>>> will go toward integrating key components of Django REST Framework into >>>>>> Django. >>>>>> >>>>>> Since I haven't found any update since the initial announcement in >>>>>> December, I was curious what the status of this integration is and, if >>>>>> possible, how soon it might be available. >>>>>> >>>>>> >>>>>> https://www.djangoproject.com/weblog/2015/dec/11/django-awarded-moss-grant/ >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Django developers (Contributions to Django itself)" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to django-develop...@googlegroups.com. >>>>>> To post to this group, send email to django-d...@googlegroups.com. >>>>>> Visit this group at https://groups.google.com/group/django-developers >>>>>> . >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/d/msgid/django-developers/2bdf074c-5e21-48cf-a93c-ba19f7744a89%40googlegroups.com >>>>>> >>>>>> <https://groups.google.com/d/msgid/django-developers/2bdf074c-5e21-48cf-a93c-ba19f7744a89%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>> >>>>> >>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Django developers (Contributions to Django itself)" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to django-develop...@googlegroups.com. >>>> To post to this group, send email to django-d...@googlegroups.com. >>>> Visit this group at https://groups.google.com/group/django-developers. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/django-developers/dbc29625-3af4-4b73-9b60-78d269352d52%40googlegroups.com >>>> >>>> <https://groups.google.com/d/msgid/django-developers/dbc29625-3af4-4b73-9b60-78d269352d52%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers (Contributions to Django itself)" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to django-develop...@googlegroups.com <javascript:>. >> To post to this group, send email to django-d...@googlegroups.com >> <javascript:>. >> Visit this group at https://groups.google.com/group/django-developers. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/a5d0f33d-882f-4e02-9191-281594ff5522%40googlegroups.com >> >> <https://groups.google.com/d/msgid/django-developers/a5d0f33d-882f-4e02-9191-281594ff5522%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/0e287bef-c8a7-4a12-a5bc-fed3f05d57c1%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
