> > I apologise if adding the tests has made it harder to improve the > behaviour of the tag.
I don't think you have anything to apologise for! More tests is always better. This has clarified the current behaviour 👌 On 6 January 2017 at 10:15, Alasdair Nicol <[email protected]> wrote: > Hi, > > On Thursday, 5 January 2017 17:51:39 UTC, Tim Martin wrote: >> >> >> >> On Thursday, 5 January 2017 04:15:31 UTC, Carl Meyer wrote: >>> >>> Hi Tim, >>> >>> On 01/04/2017 03:39 PM, Tim Martin wrote: >>> >>> > 1) There are test cases where we have templates that should treat "x >>> > is y" as True where x and y are both undefined. >>> >>> Really? Is this an accidental side effect of some historical change, or >>> really the intent of the test? That behavior seems buggy to me; more >>> likely to be a bug-magnet than useful. >>> >> >> There are a couple of test cases in test_if.py: >> test_if_is_both_variables_missing and test_if_is_not_both_variables_missing. >> These are verifying this specific case, so they haven't been introduced by >> accident. I haven't got as far as figuring out whether it was a fully >> thought through decision or whether someone just created these cases for >> completeness. >> > > I added the tests in ticket 26479 (see comment 5 onwards) [1]. I believe I > added them for consistency with == and != operators, which have similar > tests [2], [3] (trickier to spot because they are numbered). I apologise if > adding the tests has made it harder to improve the behaviour of the tag. > > cheers, > Alasdair > > [1]: https://code.djangoproject.com/ticket/26479#comment:5 > [2]: https://github.com/django/django/blob/master/tests/ > template_tests/syntax_tests/test_if.py#L85 > [3]: https://github.com/django/django/blob/master/tests/ > template_tests/syntax_tests/test_if.py#L112 > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/django-developers/96f764fa-25c6-4104-9b6b- > 8226e3b6bd8f%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/96f764fa-25c6-4104-9b6b-8226e3b6bd8f%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- Adam -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM1_EWy8PTCbvQF1qU4vPAWtALpCJzFm7-dfQtU2JuR_Fw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
