Once in a while, there's a ticket about this behavior:
m = Model(decimal='12.9')
m.save()
self.assertEqual(m.decimal, '12.9')
m.refresh_from_db()
self.assertEqual(m.decimal, Decimal('12.9'))
That is, you can create a model with an incorrect type and it won't be
fixed until you refresh the object from the database.
Most recent complaint, "it is only a basic expectation that the DB layer
and the Application layer will correspond to each-other after performing
save, which is in other words, syncing your state with the DB. Personally,
this bug (one way binding between application and db on save) broke many of
my tests and took a lot of my time." [0] See [1] for another manifestation
of this.
I think calling to_python() in Model.save() would have unacceptable
performance consequences for little benefit considering that it's a
reasonable expectation for developers to provide the correct type. Further,
you can use full_clean() to coerce to the correct types:
m = Model(decimal='12.9')
m.full_clean()
self.assertEqual(m.decimal, Decimal('12.9'))
What do you think? Absent a better suggestion, we could document this
pitfall so that there's something to point to when related tickets come in.
[0] https://code.djangoproject.com/ticket/27825
[1] https://code.djangoproject.com/ticket/24028
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/68e9d568-c627-4734-847a-1d7ac934281f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
