I've had a quick look at the PR and discussions. The ability to stream template rendering looks fantastic and I know I've seen on a few features in projects that could take advantage of it.
I agree with Carlton's last comment on the PR though. Adding all the extra classes to Django is a bit of a combinatorial explosion, and most of the code saves just a couple lines of code for the user. Normally we are conservative on adding extra stuff to Django: we want to support it until the heat death of the universe, the termination of the internet, or its deprecation (whichever comes first). Thank you for your work on this long-standing ticket and I hope we can get it merged in time for Django 3.0's feature freeze! On Sat, 20 Jul 2019 at 07:27, Carlton Gibson <[email protected]> wrote: > It's not really a recent discussion. 🙂 > > The original mailing list thread here was from 2015: > > https://groups.google.com/d/topic/django-developers/kuGeu7ffJsc/discussion > > I based my comments on the PR on a review + Aymeric and Tom's previous > reviews there, which were never acted on. > > I quoted Tom on the PR but, as I said there, his and Aymeric's points are > well worth reviewing in full. > > Here's a particular extract from Aymeric: > > > I set a bad precedent when I added StreamingHttpResponse. I didn't think > of HttpResponse(stream=True) at the time. The prospect of having 25 > StreamingFooBar classes in Django makes me realize this wasn't a great > idea. Let's learn from this mistake. > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/754f4f5b-6257-49d4-bfd1-98fbf9b0738c%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/754f4f5b-6257-49d4-bfd1-98fbf9b0738c%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- Adam -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM1DCx7cRQ1kHW-ugjWQ2V3oYR2sfna-WbYFn6o%2BJb0hRw%40mail.gmail.com.
