#14800: Development server should NOT elide favicon from the logs
-------------------------------------+-------------------------------------
Reporter: RoySmith | Owner:
Type: New feature | Status: new
Component: Core (Management | Version: 1.2
commands) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: logging | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by aaugustin):
Does this mean the following fix would be sufficient to make everyone
happy?
{{{
--- a/django/core/servers/basehttp.py
+++ b/django/core/servers/basehttp.py
@@ -156,7 +156,7 @@ class
WSGIRequestHandler(simple_server.WSGIRequestHandler, object):
def log_message(self, format, *args):
# Don't bother logging requests for admin images or the favicon.
if (self.path.startswith(self.admin_static_prefix)
- or self.path == '/favicon.ico'):
+ or (self.path == '/favicon.ico' and args[1] == '404')):
return
msg = "[%s] %s\n" % (self.log_date_time_string(), format % args)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/14800#comment:17>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
