#20288: admin popup querystring inconsistency
-------------------------------------+-------------------------------------
Reporter: Keryn Knight | Owner: nobody
<django@…> | Status: new
Type: | Version: master
Cleanup/optimization | Resolution:
Component: contrib.admin | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Changes (by loic84):
* needs_better_patch: 0 => 1
Comment:
This patch is a no-go in my opinion.
1. We can't standardize to just "pop", it works for the changelist, but
nowhere else, `add_view` accepts arbitrary querystring parameters for
prefilling purpose, (i.e. /admin/auth/user/add/?username=hello). "pop"
would clash with any model field out there named "pop".
2. `{% get_popup_var as popup_var %}`. We shouldn't be manipulating the
querystring in the templates, we do it, it's bad, but let's not add
complexity. `?_popup=1` is a hack, let's not make it a bigger hack.
3. `IS_POPUP_VAR` is only used to disable some feature of ChangeList when
it's in a popup (raw ID widget), it would be much more compatible to just
change `IS_POPUP_VAR` to `_popup`, than to rename every occurences of
`_popup` to `IS_POPUP_VAR`.
--
Ticket URL: <https://code.djangoproject.com/ticket/20288#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/095.a7f02720538ba9977904324faa53bb1c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
