#20288: admin popup querystring inconsistency
-------------------------------------+-------------------------------------
     Reporter:  Keryn Knight         |                    Owner:  nobody
  <django@…>                         |                   Status:  new
         Type:                       |                  Version:  master
  Cleanup/optimization               |               Resolution:
    Component:  contrib.admin        |             Triage Stage:  Accepted
     Severity:  Normal               |      Needs documentation:  0
     Keywords:                       |  Patch needs improvement:  1
    Has patch:  1                    |                    UI/UX:  0
  Needs tests:  0                    |
Easy pickings:  1                    |
-------------------------------------+-------------------------------------

Comment (by loic84):

 PR https://github.com/django/django/pull/1285

 I didn't add `is_popup_var`, I think it adds noise to those already
 humongous {% url %} tag in the admin templates. We would still have to
 hardcode that value in the JavaScript anyway.

 For the full deprecation cycle I also have my doubts, seems overkill
 considering the small reach of this issue now that we only modify the
 `ChangeList`.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/20288#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.0b37b8b3c2f68b3c2492d6ebdb0bb117%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to