#20288: admin popup querystring inconsistency
-------------------------------------+-------------------------------------
Reporter: Keryn Knight | Owner: nobody
<django@…> | Status: new
Type: | Version: master
Cleanup/optimization | Resolution:
Component: contrib.admin | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Changes (by bmispelon):
* cc: bmispelon@… (added)
Comment:
Hi,
Regarding 1., I agree that the potential for name collision could is a
problem.
Prefixing the variable name with an underscore would alleviate this issue.
Consequently, if we're going to change the value of `IS_POPUP_VAR`, it
makes sense to re-use `_popup` I think (point 3.).
I don't completely agree with point 2, but I still think a custom tag
might be overkill.
How about passing the `IS_POPUP_VAR` to the context of the templates
instead?
The patch also needs to introduce explicit deprecation warnings for the
old `IS_POPUP_VAR`, as per our deprecation policy [1].
Finally, this change should be mentionned in the release notes.
Thanks.
[1] https://docs.djangoproject.com/en/dev/internals/release-process
/#internal-release-deprecation-policy
--
Ticket URL: <https://code.djangoproject.com/ticket/20288#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/095.c5cf3013ef99135d3440c3957a3510c0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
