#22804: A warning should be issued when an invalid separator is passed to signing.Signer --------------------------------------+------------------------------------ Reporter: wolever | Owner: nobody Type: Cleanup/optimization | Status: new Component: Core (Other) | Version: 1.6 Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 1 Easy pickings: 0 | UI/UX: 0 --------------------------------------+------------------------------------ Changes (by bmispelon):
* needs_better_patch: 0 => 1 * has_patch: 0 => 1 * type: Uncategorized => Cleanup/optimization * stage: Unreviewed => Accepted Comment: Hi, I'll mark this as accepted on the basis that the current behavior leaves the user open to serious issues. However, wouldn't it be better to go through the deprecation process and raise an error eventually? I can't think of a reason why a user would want to pass a separator that has a chance to appear in the encoded data. Thanks. -- Ticket URL: <https://code.djangoproject.com/ticket/22804#comment:2> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.4893a4f7ce904e7a375c768104ec0985%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.