#22804: A warning should be issued when an invalid separator is passed to
signing.Signer
--------------------------------------+------------------------------------
Reporter: wolever | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: 1.6
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by wolever):
Yep - would definitely agree it should go through the deprecation process
and raise an error eventually. I'd be -0 on raising an error immediately
because invalid separators can appear to work (I was using "-" as a
separator on a low traffic internal thing), and halting application
entirely could be even less helpful. Proposal for now:
1) Change warning to deprecation warning
2) If a bad signature error is raised, check to see if the sep is invalid
and augment the error message if it is (ex, `InavlidSignature("the
signature was invalid; NOTE: the separator '-' is not valid; this may be
the cause of the invalid signature")`)
3) Raise an exception in the future (as per whatever deprecation timeline
is sensible)
--
Ticket URL: <https://code.djangoproject.com/ticket/22804#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.922fb97cb2ebc81a25b73d62671d6aea%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
