#24227: isinstance checks on ManyToManyField should be replaced with
field.many_to_many
-------------------------------------+-------------------------------------
Reporter: coldmind | Owner: coldmind
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by claudep):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/6236 PR]
It's not always obvious to know if `isinstance(field, ForeignKey)` should
be replaced by `field.many_to_one` or by `field.many_to_one or
field.one_to_one`, as OneToOneField is a ForeignKey subclass. Trusting the
test suite at this regard.
--
Ticket URL: <https://code.djangoproject.com/ticket/24227#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.1331f4d6717e834290a3170f70304553%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
