#24227: isinstance checks on ManyToManyField should be replaced with
field.many_to_many
-------------------------------------+-------------------------------------
Reporter: coldmind | Owner: coldmind
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by claudep):
I think, but unfortunately don't remember exactly when, that I have been
bitten at some point by the `isinstance(f, ManyToManyField)` in the
`django.forms.models.model_to_dict` function (I had a branch with that
change).
In any case, duck typing is clearly a better pattern than `isinstance`
calls in most cases, that's why I think we should go forward with this.
Wrt error messages, we could for instance change `ForeignKey` by `foreign
key` when appropriate.
--
Ticket URL: <https://code.djangoproject.com/ticket/24227#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.8b0b0442365c86687c7ce745c6fcd19d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
