#24227: isinstance checks on ManyToManyField should be replaced with
field.many_to_many
-------------------------------------+-------------------------------------
Reporter: coldmind | Owner: coldmind
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by timgraham):
It's not obvious to me if all of the replacements as proposed are better
than `isinstance`, especially where we hardcode class names like
`ForeignKey` in error messages. I would be more comfortable not making any
changes until we have specific use cases where the current checks are
problematic, but I'd like to hear other opinions. If we could find some
third-party fields that are making use of these flags, I think that would
be quite useful for evaluating whether this change is useful. Did you have
a specific motivation for completing this?
--
Ticket URL: <https://code.djangoproject.com/ticket/24227#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.c10254d4fea4f4004d3a5ad7b6fd79bb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
