#29303: non_atomic_requests decorator alters _non_atomic_requests attribute of
original function
-------------------------------------+-------------------------------------
Reporter: Alasdair | Owner: nobody
Nicol |
Type: Bug | Status: new
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
When calling `non_atomic_requests` with a function, it alters the
`_non_atomic_requests` attribute of the original function.
Here's an example:
{{{
from django.db import transaction
@transaction.non_atomic_requests(using='default')
def my_view(request):
return HttpResponse('')
assert my_view._non_atomic_requests == {'default'} # passes
wrapped_view = transaction.non_atomic_requests(using='other')
assert wrapped_view._non_atomic_requests == {'default', 'other'} # passes
assert my_view._non_atomic_requests == {'default'} # fails
}}}
I realise that this is a contrived example. It isn't an issue when
`non_atomic_requests` is used as a decorator:
{{{
@transaction.non_atomic_requests(using='default')
@transaction.non_atomic_requests(using='other')
def my_view(request)
return HttpResponse('')
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29303>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/056.1583a1f6825312d24bf28d51b9e0cf35%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
