#29303: non_atomic_requests decorator alters _non_atomic_requests attribute of
original function
-------------------------------------+-------------------------------------
     Reporter:  Alasdair Nicol       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham):

 I'm not able to reproduce. I created this test file:
 {{{ #!python
 from django.test import TestCase
 from django.db import transaction

 @transaction.non_atomic_requests(using='default')
 def my_view(request):
     return HttpResponse('')

 class TestViews(TestCase):

     def test(self):
         assert my_view._non_atomic_requests == {'default'}  # passes

         wrapped_view = transaction.non_atomic_requests(using='other')

         assert wrapped_view._non_atomic_requests == {'default', 'other'}
 # passes
         assert my_view._non_atomic_requests == {'default'}  # fails
 }}}
 I get:
 {{{
 Traceback (most recent call last):
   File "/home/tim/code/mysite/polls/test_29303.py", line 15, in test
     assert wrapped_view._non_atomic_requests == {'default', 'other'}  #
 passes
 AttributeError: 'function' object has no attribute '_non_atomic_requests'
 }}}
 and if I remove the assertion, the next assertion passes.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29303#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.e0e13ed79c04ebbbe34ae2077bef6823%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to