#29303: non_atomic_requests decorator alters _non_atomic_requests attribute of
original function
-------------------------------------+-------------------------------------
     Reporter:  Alasdair Nicol       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Old description:

> When calling `non_atomic_requests` with a function, it alters the
> `_non_atomic_requests` attribute of the original function.
>
> Here's an example:
>
> {{{
> from django.db import transaction
>
> @transaction.non_atomic_requests(using='default')
> def my_view(request):
>     return HttpResponse('')
>
> assert my_view._non_atomic_requests == {'default'}  # passes
>
> wrapped_view = transaction.non_atomic_requests(using='other')
>
> assert wrapped_view._non_atomic_requests == {'default', 'other'}  #
> passes
> assert my_view._non_atomic_requests == {'default'}  # fails
> }}}
>
> I realise that this is a contrived example. It isn't an issue when
> `non_atomic_requests` is used as a decorator:
>
> {{{
> @transaction.non_atomic_requests(using='default')
> @transaction.non_atomic_requests(using='other')
> def my_view(request)
>     return HttpResponse('')
> }}}

New description:

 When calling `non_atomic_requests` with a function, it alters the
 `_non_atomic_requests` attribute of the original function.

 Here's an example:

 {{{
 from django.test import TestCase

 # Create your tests here.

 from django.test import TestCase
 from django.db import transaction

 @transaction.non_atomic_requests(using='default')
 def my_view(request):
         return HttpResponse('')

 class TestViews(TestCase):

     def test(self):
         assert my_view._non_atomic_requests == {'default'}  # passes

         wrapped_view =
 transaction.non_atomic_requests(using='other')(my_view)

         assert wrapped_view._non_atomic_requests == {'default', 'other'}
 # passes
         assert my_view._non_atomic_requests == {'default'}  # fails
 }}}

 I realise that this is a contrived example. It isn't an issue when
 `non_atomic_requests` is used as a decorator:

 {{{
 @transaction.non_atomic_requests(using='default')
 @transaction.non_atomic_requests(using='other')
 def my_view(request)
     return HttpResponse('')
 }}}

--

Comment (by Alasdair Nicol):

 Sorry, there was a mistake in the `wrapped_view` line, I didn't apply it
 to the view. It should be:

 {{{
 wrapped_view = transaction.non_atomic_requests(using='other')(my_view)
 }}}

 I've updated the example in the ticket description.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29303#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.b1f30871a731bb70685d7828f420f6f4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to