#29688: ModelAdmin: Add attribute to override manager used by
ModelAdmin.get_queryset()
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: nobody
Type: New feature | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* status: new => closed
* resolution: => wontfix
Comment:
Right, Tim seems to be studiously ignoring this one — which is 100% fair,
since there's no reason he has to make all the decisions.
As such, I'm going to say `wontfix` to this one.
1. In general the cognitive overload on the ModelAdmin API is already
high-enough, and I'm predisposed against adding more API there.
2. In particular I think the supposed benefit accrued from having a
declarative attribute is minimal at best and users are better-off
overriding `get_queryset()` directly. (The purpose of `get_queryset()` is
clear-as-day. The function of a `manager_name` is not. Thus in the latter
case I'm off to the docs.)
Jon, I hope you understand these points, even if you don't agree with
them. I'm very happy if you want to pick it up on django-developers to
discuss.
(It might be interesting to sound out general opinions on the ModelAdmin
API.)
--
Ticket URL: <https://code.djangoproject.com/ticket/29688#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.3ab873fa7f05fc86707f471d8b8c8d1a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
