#30179: Merging 3 or more media objects can throw unnecessary
MediaOrderConflictWarnings
-----------------------------------------+------------------------
Reporter: Matt Westcott | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
Consider the following form definition, where `text-editor-extras.js`
depends on `text-editor.js` but all other JS files are independent:
{{{
from django import forms
class ColorPicker(forms.Widget):
class Media:
js = ['color-picker.js']
class SimpleTextWidget(forms.Widget):
class Media:
js = ['text-editor.js']
class FancyTextWidget(forms.Widget):
class Media:
js = ['text-editor.js', 'text-editor-extras.js', 'color-
picker.js']
class MyForm(forms.Form):
background_color = forms.CharField(widget=ColorPicker())
intro = forms.CharField(widget=SimpleTextWidget())
body = forms.CharField(widget=FancyTextWidget())
}}}
Django should be able to resolve the JS files for the final form into the
order text-editor.js, text-editor-extras.js, color-picker.js. However,
accessing `MyForm().media` results in:
{{{
/projects/django/django/forms/widgets.py:145: MediaOrderConflictWarning:
Detected duplicate Media files in an opposite order:
text-editor-extras.js
text-editor.js
MediaOrderConflictWarning,
Media(css={}, js=['text-editor-extras.js', 'color-picker.js', 'text-
editor.js'])
}}}
The `MediaOrderConflictWarning` is a result of the order that the
additions happen in: `ColorPicker().media + SimpleTextWidget().media`
produces `Media(css={}, js=['color-picker.js', 'text-editor.js'])`, which
(wrongly) imposes the constraint that color-picker.js must appear before
text-editor.js.
The final result is particularly unintuitive here, as it's worse than the
"naïve" result produced by Django 1.11 before order-checking was added
(color-picker.js, text-editor.js, text-editor-extras.js), and the pair of
files reported in the warning message seems wrong too (aren't color-
picker.js and text-editor.js the wrong-ordered ones?)
--
Ticket URL: <https://code.djangoproject.com/ticket/30179>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/049.25c6654998a141eaee4c78cc6f631a4d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
