#30179: Merging 3 or more media objects can throw unnecessary
MediaOrderConflictWarnings
-------------------------------+------------------------------------
Reporter: Matt Westcott | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Comment (by Matthias Kestenholz):
I don't think sorting by length is the way to go - it would be trivial to
make the test fail again by extending the first list with unrelated items.
It might be a good real-world heuristic for finding a solution more often,
but that's just trading a reproducible bug for an unpredictable one.
Well yes, if the `ColorPicker` itself would have a longer list of JS files
it depends on then it would fail too. If, on the other hand, it wasn't a
`ColorPicker` widget but a `ColorPicker` formset or form the initially
declared lists would still be preserved and sorting the lists by length
would give the correct result.
Since #30153 the initially declared lists (or tuples) are preserved so
maybe you have many JS and CSS declarations but as long as they are
unrelated there will not be many long sublists.
I'm obviously happy though if you're willing to spend the time finding a
robust solution to this problem.
(For the record: Personally I was happy with the state of things pre-2.0
too... and For the record 2: I'm also using custom widgets and inlines in
feincms3/django-content-editor. It's really surprising to me that we
didn't stumble on this earlier since we're always working on the latest
Django version or even on pre-release versions if at all possible)
--
Ticket URL: <https://code.djangoproject.com/ticket/30179#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.b2bac82ac549e7d9a84d1c3c69f237fe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
