#30179: Merging 3 or more media objects can throw unnecessary
MediaOrderConflictWarnings
-------------------------------+------------------------------------
Reporter: Matt Westcott | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Comment (by Johannes Hoppe):
Hi there,
I'm the dude who implemented the warning.
I am not so sure this is a bug. Let's try tackle this step by step.
The new merging algorithm that was introduced in version 2 is an
improvement. It is the most accurate way to merge two sorted lists. It's
not the simplest way, but has been reviewed plenty times.
The warning is another story. It is independent from the algorithm. It
merely tells you that the a certain order could not be maintained. We
figured back than, that this would be a good idea. It warns a developer
about a potential issue, but does not raise an exception. With that in
mind, the correct way to deal with the issue described right now, is to
ignore the warning.
BUT, that doesn't mean that you don't have a valid point. There are
implicit and explicit orders. Not all assets require ordering and (random)
orders that only exist because of Media merging don't matter at all.
This brings me back to a point that I have [previously
made](https://code.djangoproject.com/ticket/30153#comment:6). It would
make sense to store the original lists, which is now the case on master,
and only raise if the order violates the original list.
The current implementation on master could also be improved by removing
duplicates.
Anyways, I would considers those changes improvements, but not bug fixes.
I didn't have time yet to look into this. But I do have some time this
weekend. If you want I can take another look into this and propose a
solution that solves this issue.
Best
-Joe
--
Ticket URL: <https://code.djangoproject.com/ticket/30179#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.4678e948079966277ce57d20f9b31a7f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
