#4036: Spanish (es) localflavor
------------------------------------------------+---------------------------
   Reporter:  [EMAIL PROTECTED]         |                Owner:  garcia_marc    
           
     Status:  new                               |            Component:  
django.contrib.localflavor
    Version:  SVN                               |           Resolution:         
                   
   Keywords:  spanish es l10n i18n localflavor  |                Stage:  
Accepted                  
  Has_patch:  1                                 |           Needs_docs:  0      
                   
Needs_tests:  1                                 |   Needs_better_patch:  0      
                   
------------------------------------------------+---------------------------
Changes (by garcia_marc):

  * needs_better_patch:  1 => 0

Comment:

 Finally I uploaded an updated patch for this ticket.

 I've added some new fields (phone number and bank account), and I modified
 some features of old NIF/CIF functions. Main changes are:
 * When NIF or NIE, it does not check number length (most NIFs have 8
 digits, but actually it is a sequential number that started on 1).
 * When CIF, it is valid both number or letter checksum, so there is no
 official documentation on it, and different authors have different
 opinions on which company types can have both checksum types.
 * I left just a parameter for allowing only nif or nie values (not cif).
 Allowing only cif values is meaningless, so if idea is restricting just
 companies, there is a type that uses owners nif as identity number. I
 cannot imagine any case that somebody would want to avoid this case of
 companies in validation.
 * Message errors are more detiled now.

 This patch is well tested using forms, but there are missing regression
 tests, so I don't know if there are based on any documentation that I
 cannot found, or using any script. Could anybody help me on it please?
 After that and any commiter review it'll be ready for check in.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/4036#comment:13>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to