#31320: Prevent BEGIN and COMMIT in RunSQL in atomic migrations.
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: nobody
Johnson |
Type: New feature | Status: closed
Component: Migrations | Version: master
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Adam (Chainz) Johnson):
I'm pretty sure sqlparse parses the `BEGIN` statement differently ot the
keyword in `DO ... BEGIN .. END`. And we already parse the SQL in RunSQL
for splitting, so it doesn't seem like it would be much overhead to me to
make a pass over the tokens at that point and warn/error. Migrations using
`BEGIN` / `COMMIT` could possibly cause data loss so I think it's a fair
case to guard against.
--
Ticket URL: <https://code.djangoproject.com/ticket/31320#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.9ccf7bc9360c9a2a00f3474c834da408%40djangoproject.com.
